Branko Čibej wrote on Tue, Sep 04, 2012 at 13:24:42 +0200: > On 01.09.2012 23:41, Daniel Shahaf wrote: > > Branko Čibej wrote on Sat, Sep 01, 2012 at 06:55:40 +0200: > >> On 01.09.2012 06:48, br...@apache.org wrote: > >>> Author: brane > >>> Date: Sat Sep 1 04:48:26 2012 > >>> New Revision: 1379689 > >>> > >>> URL: http://svn.apache.org/viewvc?rev=1379689&view=rev > >>> Log: > >>> First step towards making client version informatin usable by other than > >>> the svn command-line client. > >>> > >>> * subversion/libsvn_subr/opt.h (svn_opt__get_version_info): Renamed from > >>> svn_opt__print_version_info and prototype changed to return a string. > >>> Updated docstring. > >> The plan here is to make svn_opt__get_version_info public, so that other > >> clients built on top of the core Subversion libraries -- e.g., > >> TortoiseSVN -- can use it directly instead of having to construct their > >> own version info. > >> > >> I /think/ this would be a useful addition to the API, but would welcome > >> any comments on this plan. > >> > > Currently the function constructs and returns a string. For API use > > maybe it should return a struct? > > Updated to do just that in r1380559. Comments welcome.
Looks good to me, thanks.
