Stefan Sperling wrote: > On Tue, Sep 04, 2012 at 03:01:22PM -0400, Paul Burba wrote: >> I just noticed that this causes a segfault when updating with >> the quiet option: > > Thanks for digging into this and explaining the problem, Paul. > > I cannot think of a better way to fix this than recording in > opt_state whether the notifier is being used. That way we > have a way of telling whether it is safe to ask the notifier > for a list of conflicted paths. > > What you do think?
Just a drive-by comment: isn't "ctx->notify_func2 != NULL" a good "notifier is in use" flag? (And I removed 'commits@' from the CC.) - Julian
