> -----Original Message-----
> From: Neil Bird [mailto:[email protected]]
> Sent: maandag 17 september 2012 03:07
> To: Josh Triplett
> Cc: C. Michael Pilato; [email protected]
> Subject: Re: [PATCH] Add support for http_proxy and https_proxy
> environment variables
>
> Around about 13/09/12 15:50, Josh Triplett typed ...
> > Why should only the command-line clients notice those environment
> > variables? If someone has http_proxy set, and runs some graphical
> > subversion client using libsvn, that client ought to use the proxy as
> > well.
>
> As a user of http_proxy on both platforms, that is what I'd expect (i.e.,
> always honoured).
But this doesn't answer the other questions I asked earlier in this thread.
On Windows this isn't the normal way to fetch the system wide proxy, nor is it
on the Mac. Adding environment flags to GUI applications there is certainly
*not* the right way to look at this problem. The linux specific environment
variable solution might apply to a linux gui, but not to a Windows gui or a
Windows/Mac shell or application extension.
My earlier suggestion was to use libproxy, as that handles the normal settings
on all these platforms. On Linux it appears to use these proxy environment
variables (and a few others) as that appears to be the common way to configure
a proxy there, while on the Mac and Windows it properly looks at the system
proxy settings. It also handles corner cases like the support for ignoring
proxies for specific hosts.
As libproxy is LGPL I don't think we can add it as an explicit dependency, but
adding it as an optional dependency would be a proper solution. When
encapsulated properly we can also add specific implementations for other
platforms ourselves.
(Windows XP and later appear to have a standard API that handles all kinds of
proxies, including pac files which would require some Mozilla components via
libproxy)
Bert
