On Thu, Sep 20, 2012 at 9:22 PM, Branko Čibej <br...@wandisco.com> wrote:
> On 20.09.2012 13:41, stef...@apache.org wrote: > > +Bottlenecks to address: > > + > > +* frequent cancellation checks (intense OS interaction) > > I don't understand this part: since when do cancellation checks involve > interaction with the OS? I thought the cancellation flag was an (atomic, > volatile) thing that requires neither cpu-level atomic operations, nor > higher-level locking. > It may not actually be "the OS" but the phenomenon is real. check_for_error() in ra_svn/editorp.c calls apr_poll(), which in turn calls select(). To make things worse, we buffer small output data like props etc. but check for errors after each of them. So, more select() calls then socket writes ... My idea is to short-circuit the check until at least x amount of data has been sent. -- Stefan^2. -- * Join us this October at Subversion Live 2012<http://www.wandisco.com/svn-live-2012> for two days of best practice SVN training, networking, live demos, committer meet and greet, and more! Space is limited, so get signed up today<http://www.wandisco.com/svn-live-2012> ! *
