On 09/26/2012 09:51 AM, C. Michael Pilato wrote:
> On 09/26/2012 09:40 AM, Philip Martin wrote:
>> Serf sends the delta base to the server (what does TEMPORARILY mean
>> here?):
>>
>> /** This header is *TEMPORARILY* used to transmit the delta base to the
>>  * server. It contains a version resource URL for what is on the client.
>>  */
>> #define SVN_DAV_DELTA_BASE_HEADER "X-SVN-VR-Base"
> 
> Hrm... I do wonder what "TEMPORARILY" was intended to mean there.  Maybe
> there was some Delta-V-ism that we were supposed to be using but didn't?
> 
> Ah!  Neon's use of this header explains it:
> 
> {{{
>       /* The HTTP delta draft uses an If-None-Match header holding an
>          entity tag corresponding to the copy we have. It is much more
>          natural for us to use a version URL to specify what we have.
>          Thus, we want to use the If: header to specify the URL. But
>          mod_dav sees all "State-token" items as lock tokens. When we
>          get mod_dav updated and the backend APIs expanded, then we
>          can switch to using the If: header. For now, use a custom
>          header to specify the version resource to use as the base. */
>       ne_add_request_header(request->ne_req,
>                             SVN_DAV_DELTA_BASE_HEADER, delta_base);
> }}}
> 

I've taken the liberty of porting this information into the docstring for
SVN_DAV_DELTA_BASE_HEADER for increased visibility (r1390487).

-- 
C. Michael Pilato <cmpil...@collab.net>
CollabNet   <>   www.collab.net   <>   Enterprise Cloud Development

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to