On 10/24/2012 09:25 AM, vijay wrote: > On Wednesday 24 October 2012 02:33 AM, Ben Reser wrote: >> Does it make more sense to make --include-externals behave something >> more like --depth rather than a simple boolean? >> >> E.G. it'd behave like so: >> >> No option: current behavior externals are not processed. >> --include-externals or --include-externals=infinity : Fully recursive. >> --include-externals=immediate : Only externals defined in the repo for >> the target.
Externals are today always generated with full recursion, because a) the responsibility for deciding at what depth an external working copy is interesting lies with the author of that externals definition, and b) today, we don't allow authors to make such a declaration (all externals are depth-infinity). The shortcomings of our externals definition format doesn't, however, change the assignment of responsibility here! So, no, I think --include-externals=DEPTH takes us down the wrong path. In fact, IIRC, our existing commands (svn export) will only process externals at all when run with full recursion anyway, so perhaps the consistent thing to do is to only honor --include-externals (as a boolean) when --depth=infinity for 'svn ls', too. -- C. Michael Pilato <cmpil...@collab.net> CollabNet <> www.collab.net <> Enterprise Cloud Development
signature.asc
Description: OpenPGP digital signature
