Prabhu Gnana Sundar <[email protected]> wrote:
> Index: subversion/libsvn_repos/dump.c
[...]
>
> +void
Doc string?
> +notify_verification_error(svn_revnum_t rev, svn_error_t *err,
> + svn_repos_notify_func_t notify_func,
> + void *notify_baton, apr_pool_t *pool)
One argument per line please, like all the rest of the code.
[...]
> /* Verify global/auxiliary data and backend-specific data first. */
> - SVN_ERR(svn_fs_verify(svn_fs_path(fs, pool), cancel_func, cancel_baton,
> - start_rev, end_rev, pool));
> + err = svn_fs_verify(svn_fs_path(fs, pool), cancel_func, cancel_baton,
> + start_rev, end_rev, pool);
> + if (err && keep_going)
> + {
> + rev = SVN_INVALID_REVNUM;
> + notify_verification_error(rev, err, notify_func, notify_baton,
> + iterpool);
> + svn_error_clear(err);
> + }
> + else
> + return svn_error_trace(err);
Wrongly returns here if the svn_fs_verify() call did not return an error.
>
> /* Create a notify object that we can reuse within the loop. */
> if (notify_func)
- Julian
