On Sun, Nov 4, 2012 at 3:40 PM, Branko Čibej <br...@wandisco.com> wrote:
> On 04.11.2012 12:37, Blair Zajac wrote: > > On Nov 4, 2012, at 2:14 AM, stef...@apache.org wrote: > > > >> Author: stefan2 > >> Date: Sun Nov 4 10:14:56 2012 > >> New Revision: 1405517 > >> > >> URL: http://svn.apache.org/viewvc?rev=1405517&view=rev > >> Log: > >> Silence integer size conversion warnings in JavaHL under Win64 by > casting > >> the values explicitly. We assume that argument counts and property > sizes > >> are all well below the 2G limit. > > Hi Stefan, > > > > Since you're in C++ here you could switch to using static_cast<> or > reinterpret_cast<> instead, that would be better for self documentation, > although that doesn't seem to be the style in the code. > > static_cast. *not* reinterpret_cast, which we should never need in > high-level code. > Yes, if APR and JNI would provide a proper C++ interfaces ... Currently, we need to cast void*->something, char*->unsigned char* etc. But at least a simple grep will now find them all. -- Stefan^2. -- Certified & Supported Apache Subversion Downloads: * http://www.wandisco.com/subversion/download *
