On Sun, Nov 11, 2012 at 4:48 PM, Daniel Shahaf <d...@daniel.shahaf.name>wrote:
> Johan Corveleyn wrote on Sun, Nov 11, 2012 at 09:46:00 +0100: > > On Sat, Nov 10, 2012 at 11:45 PM, Daniel Shahaf <d...@daniel.shahaf.name> > wrote: > > > Johan Corveleyn wrote on Sat, Nov 10, 2012 at 15:35:21 +0100: > > >> On Fri, Nov 9, 2012 at 3:14 AM, Johan Corveleyn <jcor...@gmail.com> > wrote: > > >> > > >> [...] > > >> > > >> > Now, I have pinpointed the exact revision where the problems start > for > > >> > me. It's r1338286, where Bert enabled whole program optimizations > for > > >> > release builds, in the vcnet_vcxproj.ezt file. > > >> > > > >> > Maybe I'm running into some compiler bug (that has since been fixed > in > > >> > SP1), related to whole program optimization. I'll try installing SP1 > > >> > (but not right now, it's past 3 am now :-)) and see what happens. > > >> > > >> Finally got around to it, and indeed, the problem is solved when I use > > >> VC2010 SP1. Test suite is running smoothly, and both > > >> mergeinfo-test.exe and skel-test.exe have already succeeded. > > >> > > >> Now I finally have a good developer environment again, phew. > > >> > > >> Conclusion: don't use VC2010 without SP1. > > > > > > Can we make the build scripts trap that condition? (and error out, or > > > disable whole-program optimisations) > > > > Good suggestion, but I have no idea really :-). I don't know enough > > about the build scripts and project settings, and gen-make stuff etc > > ... > > > > I don't know about conditionals in .vcproj files, but I assume it would > at least be possible to drop an #error directive guarded by an #if > directive on the compiler version. > http://code.google.com/p/notepad2-mod/issues/attachmentText?id=59&aid=590000000&name=compiler.patch&token=swu5D1m0KOU9RZ7KwjULuOxXKEI%3A1333263575004 (scroll to the bottom) We could simply forbid release builds with VS2010 RTM by #error out in e.g. svn_types.h -- Stefan^2. -- Certified & Supported Apache Subversion Downloads: * http://www.wandisco.com/subversion/download *
