"C. Michael Pilato" <cmpil...@collab.net> writes: > On 11/12/2012 08:22 AM, Ivan Zhakov wrote: >> I'm also get similar crash on Windows and MacOS. Commenting call to >> maybe_close_dir() in handle_propchange_only()/handle_local_content() >> fixes them, but increase memory usage. > > Those two call sites were "just in case" sorts of additions. Obviously, > they didn't trigger SEGFAULTs on my end, or I wouldn't have committed them. > But I didn't have any reason to believe they were critical to the > memory-reduction work, so let's just remove them. (I'll do so.)
I'm still seeing the same SEGV with r1408311: #0 0x00007ffff5b22daf in finish_report (report_baton=0x7ffff7e42cc0, pool=0x7ffff7e40028) at ../src/subversion/libsvn_ra_serf/update.c:2636 #1 0x00007ffff789ac6d in svn_wc_crawl_revisions5 (wc_ctx=0x7ffff32fc6c0, local_abspath=0x7ffff7e40168 "/home/pm/sw/subversion/obj/wc", reporter=0x7ffff5d384e0, report_baton=0x7ffff7e42cc0, restore_files=1, depth=svn_depth_unknown, honor_depth_exclude=1, depth_compatibility_trick=0, use_commit_times=0, cancel_func=0x416b43 <svn_cl__check_cancel>, cancel_baton=0x0, notify_func=0x41c4db <notify>, notify_baton=0x7ffff32fc9b0, scratch_pool=0x7ffff7e40028) at ../src/subversion/libsvn_wc/adm_crawler.c:858 #2 0x00007ffff7bc800d in update_internal (result_rev=0x0, local_abspath=0x7ffff7e40168 "/home/pm/sw/subversion/obj/wc", anchor_abspath=0x7ffff7e418a0 "/home/pm/sw/subversion/obj/wc", revision=0x7fffffffe050, depth=svn_depth_unknown, depth_is_sticky=0, ignore_externals=0, allow_unver_obstructions=0, adds_as_modification=1, timestamp_sleep=0x7fffffffe15c, notify_summary=1, ctx=0x7ffff32fc608, pool=0x7ffff7e40028) at ../src/subversion/libsvn_client/update.c:427 #3 0x00007ffff7bc8597 in svn_client__update_internal (result_rev=0x0, local_abspath=0x7ffff7e40168 "/home/pm/sw/subversion/obj/wc", revision=0x7fffffffe2b0, depth=svn_depth_unknown, depth_is_sticky=1, ignore_externals=0, allow_unver_obstructions=0, adds_as_modification=1, make_parents=0, innerupdate=0, timestamp_sleep=0x7fffffffe15c, ctx=0x7ffff32fc608, pool=0x7ffff7e40028) at ../src/subversion/libsvn_client/update.c:569 #4 0x00007ffff7b6ee45 in svn_client__checkout_internal (result_rev=0x0, url=0x7ffff32fd638 "http://localhost:8080/repos/asf/subversion/trunk", local_abspath=0x7ffff7e40168 "/home/pm/sw/subversion/obj/wc", peg_revision=0x7fffffffe2a0, revision=0x7fffffffe2b0, depth=svn_depth_unknown, ignore_externals=0, allow_unver_obstructions=0, timestamp_sleep=0x0, ctx=0x7ffff32fc608, pool=0x7ffff7e40028) at ../src/subversion/libsvn_client/checkout.c:165 #5 0x00007ffff7b6ef5a in svn_client_checkout3 (result_rev=0x0, URL=0x7ffff32fd638 "http://localhost:8080/repos/asf/subversion/trunk", path=0x7ffff32fd6e0 "wc", peg_revision=0x7fffffffe2a0, revision=0x7fffffffe2b0, depth=svn_depth_unknown, ignore_externals=0, allow_unver_obstructions=0, ctx=0x7ffff32fc608, pool=0x7ffff7e40028) at ../src/subversion/libsvn_client/checkout.c:205 #6 0x0000000000409615 in svn_cl__checkout (os=0x7ffff7feb280, baton=0x7fffffffe4b0, pool=0x7ffff7feb028) at ../src/subversion/svn/checkout-cmd.c:161 #7 0x00000000004197e4 in sub_main (argc=4, argv=0x7fffffffe958, pool=0x7ffff7feb028) at ../src/subversion/svn/main.c:2735 #8 0x00000000004199cd in main (argc=4, argv=0x7fffffffe958) at ../src/subversion/svn/main.c:2790 -- Certified & Supported Apache Subversion Downloads: http://www.wandisco.com/subversion/download