My commit <http://svn.apache.org/r1411948> causes two test failures on the Windows buildbot. It works on Ubuntu. I can (or you're welcome to) revert it if it's causing too much annoyance before I can fix it, but I'd rather work out what's actually wrong.
I assume it's an EOL problem as (1) it fails only on Windows and (2) I changed the text output method. It was using partly svn_cmdline_print*() and partly writes to svn_stream_from_stdout(). I made it use entirely the stream. This should reduce the scope for such troubles, but I guess it's changed the EOL handling somewhere. From my commit <http://svn.apache.org/viewvc/subversion/trunk/subversion/svnlook/main.c?r1=1411948&r2=1411947&pathrev=1411948>, this part might well be relevant: [[[ - SVN_ERR(svn_cmdline_printf(pool, "\nProperty changes on: %s\n%s\n", - path, under_string)); + SVN_ERR(svn_stream_printf_from_utf8(outstream, encoding, pool, + _("%sProperty changes on: %s%s"), + APR_EOL_STR, + path, + APR_EOL_STR)); + + SVN_ERR(svn_stream_printf_from_utf8(outstream, encoding, pool, + "%s" APR_EOL_STR, under_string)); ]]] Can anyone see why that should cause an EOL style change or any other change? The buildbot doesn't give me enough info in its logs. From <http://ci.apache.org/builders/svn-slik-w2k3-x64-local/builds/9083/steps/Test%20fsfs%2Blocal/logs/faillog>: [[[ W: CWD: E:\w2k3\tests\subversion\tests\cmdline Traceback (most recent call last): File "D:\svn-w2k3-local\slik-w2k3-x64-local\build\subversion\tests\cmdline\svntest\main.py", line 1424, in run rc = self.pred.run(sandbox) File "D:\svn-w2k3-local\slik-w2k3-x64-local\build\subversion\tests\cmdline\svntest\testcase.py", line 176, in run return self.func(sandbox) File "D:\svn-w2k3-local\slik-w2k3-x64-local\build\subversion\tests\cmdline\svnlook_tests.py", line 290, in test_print_property_diffs if expected_output[2].split()[1] != output[2].split()[1]: IndexError: list index out of range FAIL: svnlook_tests.py 3: test the printing of property diffs ]]] And test number 9 similarly. Can anyone get me a verbose log of the test runs? - Julian -- Subversion Live 2012 - 2 Days: training, networking, demos & more! http://bit.ly/NgUaRi Certified & Supported Apache Subversion Downloads: http://www.wandisco.com/subversion/download
