On Tue, Dec 11, 2012 at 10:48 PM, Ben Reser <b...@reser.org> wrote:
> On Tue, Dec 11, 2012 at 3:18 AM, Shivani Poddar
> <shivani.podda...@gmail.com> wrote:
> >
> > Log Message:
> >
> > Improve support for svn_checksum.h in SWIG bindings
> > * subversion/bindings/swig/python/tests/checksum.py: Improved
> test_checksum
> >
> >
> > Modified:
> > subversion/trunk/subversion/bindings/swig/python/tests/checksum.py
>
> This doesn't even pass. You really should run your code before submitting
> it.
> [[[
> ERROR: test_checksum (checksum.ChecksumTestCases)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File
> "/home/breser/wandisco/share/wcs/svn-trunk/subversion/bindings/swig/python/tests/checksum.py",
> line 39, in test_checksum
> raise Exception ("Length of Initialized digest does not match kind")
> Exception: Length of Initialized digest does not match kind
> ]]]
>
This seems to be a grave error , sorry , when i checked compiling it i
thought it ran for me. Some confusion, will check again
>
> This doesn't provide a LENGTH:
> +LENGTH =
> svn.core.svn_checksum_to_cstring_display(svn.core.svn_checksum_create(svn.core.svn_checksum_md5))
>
> Before you come back with an adjustment to just fix that... I urge
> you to consider what you're testing here. You can't just call the
> same functions twice and make sure the output matches. That doesn't
> result in a very useful test.
>
> My suggestion would be to write a function inside your test function
> that determines if the result is the proper size. There is a function
> in svn_checksum_* that provides you with the size of a digest. You
> might want to read the C code for it to get an idea of how it works
> and see if it's useful for your test. Then you could trivially expand
> your test to try both checksum kinds.
>
> yes will do that..
You've resolved the issue with the bare raises, but I'd suggest that
> we could make this code a lot cleaner and match what the other tests
> are doing but using the assert* functions like they do. I didn't
> notice this before since I'm not particularly familiar with the Python
> bindings test suite.
>
I did use the assert functions on the same line but i did understand the
earlier concerns cited that although they compiled they werent the exact
correct thing to do.I dont understand what exactly am i expected with the
raise Error functions.. okay will check those out.
Thanks a lot
Shivani Poddar,
Bachelors in Computer Sciences and MS in Exact Humanities, Sophomore
International Institute of Information Technology, Hyderabad
