On Wed, Jan 9, 2013 at 8:36 PM, Julian Foad <[email protected]>wrote:
> Stefan,
>
> > Log:
>
> > Coding style patch: in logical expressions, instead of comparing
> > with logical constants use arithmetic operations. I.e. replace
>
> No don't use arithmetic operations. Maybe write, "In *boolean*
> expressions, instead of comparing with FALSE (or, worse, with TRUE), use
> *boolean* operators."
>
> The wording should be slightly better now.
>
> > Modified: subversion/trunk/subversion/libsvn_ra_svn/client.c
> >
> ==============================================================================
> > --- subversion/trunk/subversion/libsvn_ra_svn/client.c (original)
> > +++ subversion/trunk/subversion/libsvn_ra_svn/client.c Wed Jan 9
> 19:24:52 2013
> > @@ -1304,9 +1304,9 @@ static svn_error_t *ra_svn_get_dir(svn_r
> > static svn_tristate_t
> > optbool_to_tristate(apr_uint64_t v)
> > {
> > - if (v == TRUE)
> > + if (v)
>
> No, no, not here!
>
You beat me by 2 minutes ;)
> > return svn_tristate_true;
> > - if (v == FALSE)
> > + if (!v)
> > return svn_tristate_false;
> >
> > return svn_tristate_unknown; /* Contains
> SVN_RA_SVN_UNSPECIFIED_NUMBER */
>
> Everything else looks correct.
>
Thanks for the review!
-- Stefan^2.
--
Certified & Supported Apache Subversion Downloads:
*
http://www.wandisco.com/subversion/download
*
