tests/cmdline/ MIME-Version: 1.0 Content-Type: multipart/alternative; boundary=047d7b66f6c3db7dab04d4cd9e91
--047d7b66f6c3db7dab04d4cd9e91 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Maybe we should try to fix this automatic detection then (Does your setting match the libmagic output for that file?) instead of adding just a warning when setting the file binary explicitly. Maybe we should validate our libmagic based decision to make something binary? Bert Huijben (Cell phone) From: Justin Erenkrantz Sent: 3-2-2013 9:18 To: Bert Huijben Cc: dev@subversion.apache.org Subject: Re: svn commit: r1441814 - in /subversion/trunk/subversion: svn/ tests/cmdline/ As another data point, I have hit this text-as-binary myself just a few weeks ago when I added a bunch of HTML files to a local repository - so, it's definitely occurring automatically. I did not have a chance to dig into why the magic detection failed so miserably... -- justin On Saturday, February 2, 2013, Bert Huijben wrote: > > > > -----Original Message----- > > From: s...@apache.org <javascript:;> [mailto:s...@apache.org<javascript= :;> > ] > > Sent: zaterdag 2 februari 2013 23:05 > > To: comm...@subversion.apache.org <javascript:;> > > Subject: svn commit: r1441814 - in /subversion/trunk/subversion: svn/ > > tests/cmdline/ > > > > Author: stsp > > Date: Sat Feb 2 22:04:44 2013 > > New Revision: 1441814 > > > > URL: http://svn.apache.org/viewvc?rev=3D1441814&view=3Drev > > Log: > > When a binary mime-type is set on a file that looks like a text file, > > make the 'svn' client print a warning about potential future problems > > with operations such as diff, merge, and blame. > > > > This is only done during local propset for now, because the file needs > > to be present on disk to detect its mime-type. > > > > See for related discussion: http://mail- > > archives.apache.org/mod_mbox/subversion- > > dev/201301.mbox/%3C20130131185725.GA13721%40ted.stsp.name%3E > > From my users I hear that another way this property is introduced is via > conversions from other version management systems. Visual SourceSafe (lon= g > dead, but still used in a lot of small shops) marks UTF-8 files with a BO= M > as binary when it does an auto detect. > (Well what would you guess for a system that wasn=E2=80=99t really update= d since > that format became popular) > > Most conversion tools just copy the binary flag, and there you have this > problem on all your historic utf-8 files. > (Where I worked we had this problem on all .xml files previously stored i= n > sourcesafe). > > > I don't see a lot of users accidentally adding invalid properties > themselves. > > Bert > > --047d7b66f6c3db7dab04d4cd9e91 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable <html><head><meta content=3D"text/html; charset=3Dutf-8" http-equiv=3D"Cont= ent-Type"></head><body><div><div style=3D"font-family: Calibri,sans-serif; = font-size: 11pt;">Maybe we should try to fix this automatic detection then = (Does your setting match the libmagic output for that file?) instead of add= ing just a warning when setting the file binary explicitly.<br><br>Maybe we= should validate our libmagic based decision to make something binary? <br>= <br>Bert Huijben (Cell phone)<br></div></div><hr><span style=3D"font-family= : Tahoma,sans-serif; font-size: 10pt; font-weight: bold;">From: </span><spa= n style=3D"font-family: Tahoma,sans-serif; font-size: 10pt;">Justin Erenkra= ntz</span><br><span style=3D"font-family: Tahoma,sans-serif; font-size: 10p= t; font-weight: bold;">Sent: </span><span style=3D"font-family: Tahoma,sans= -serif; font-size: 10pt;">3-2-2013 9:18</span><br><span style=3D"font-famil= y: Tahoma,sans-serif; font-size: 10pt; font-weight: bold;">To: </span><span= style=3D"font-family: Tahoma,sans-serif; font-size: 10pt;">Bert Huijben</s= pan><br><span style=3D"font-family: Tahoma,sans-serif; font-size: 10pt; fon= t-weight: bold;">Cc: </span><span style=3D"font-family: Tahoma,sans-serif; = font-size: 10pt;">dev@subversion.apache.org</span><br><span style=3D"font-f= amily: Tahoma,sans-serif; font-size: 10pt; font-weight: bold;">Subject: </s= pan><span style=3D"font-family: Tahoma,sans-serif; font-size: 10pt;">Re: sv= n commit: r1441814 - in /subversion/trunk/subversion: svn/ tests/cmdline/</= span><br><br></body></html>As another=C2=A0<span></span>data point, I have = hit this text-as-binary myself just a few weeks ago when I added a bunch of= HTML files to a local repository -=C2=A0so, it's definitely occurring = automatically. =C2=A0I did not have a chance to=C2=A0dig into why the magic= detection failed so miserably...=C2=A0 -- justin<br> <br>On Saturday, February 2, 2013, Bert Huijben wrote:<br><blockquote clas= s=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;pad= ding-left:1ex"><br> <br> > -----Original Message-----<br> > From: <a href=3D"javascript:;" onclick=3D"_e(event, 'cvml', &#= 39;s...@apache.org')">s...@apache.org</a> [mailto:<a href=3D"javascript= :;" onclick=3D"_e(event, 'cvml', 's...@apache.org')">stsp@a= pache.org</a>]<br> > Sent: zaterdag 2 februari 2013 23:05<br> > To: <a href=3D"javascript:;" onclick=3D"_e(event, 'cvml', '= ;comm...@subversion.apache.org')">comm...@subversion.apache.org</a><br> > Subject: svn commit: r1441814 - in /subversion/trunk/subversion: svn/<= br> > tests/cmdline/<br> ><br> > Author: stsp<br> > Date: Sat Feb =C2=A02 22:04:44 2013<br> > New Revision: 1441814<br> ><br> > URL: <a href=3D"http://svn.apache.org/viewvc?rev=3D1441814&view=3D= rev" target=3D"_blank">http://svn.apache.org/viewvc?rev=3D1441814&view= =3Drev</a><br> > Log:<br> > When a binary mime-type is set on a file that looks like a text file,<= br> > make the 'svn' client print a warning about potential future p= roblems<br> > with operations such as diff, merge, and blame.<br> ><br> > This is only done during local propset for now, because the file needs= <br> > to be present on disk to detect its mime-type.<br> ><br> > See for related discussion: <a href=3D"http://mail-"; target=3D"_blank"= >http://mail-</a><br> > <a href=3D"http://archives.apache.org/mod_mbox/subversion-"; target=3D"= _blank">archives.apache.org/mod_mbox/subversion-</a><br> > dev/201301.mbox/%3C20130131185725.GA13721%<a href=3D"http://40ted.stsp= .name" target=3D"_blank">40ted.stsp.name</a>%3E<br> <br> >From my users I hear that another way this property is introduced is via co= nversions from other version management systems. Visual SourceSafe (long de= ad, but still used in a lot of small shops) marks UTF-8 files with a BOM as= binary when it does an auto detect.<br> (Well what would you guess for a system that wasn=E2=80=99t really updated = since that format became popular)<br> <br> Most conversion tools just copy the binary flag, and there you have this pr= oblem on all your historic utf-8 files.<br> (Where I worked we had this problem on all .xml files previously stored in = sourcesafe).<br> <br> <br> I don't see a lot of users accidentally adding invalid properties thems= elves.<br> <br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 Bert<br> <br> </blockquote> --047d7b66f6c3db7dab04d4cd9e91--
