Julian Foad <[email protected]> writes: > Philip Martin wrote: > >> Philip Martin <[email protected]> writes: >>> What do people think? Good idea? Too ugly for the limited benefit? > > +1. Good idea and not too ugly. > > I scanned through the patch and there are just two bits I find a bit > ugly -- s/private/privat/ and s/template/templat/ -- and that's only > my subjective language preference.
Agreed. I didn't attempt to think up a good replacement. > Since the type of 'private' is id_private_t, I would suggest either > 'id_private' or 'id' would make sense for a new name. Not sure about > 'template'. The 'private' usage in serf is not an id_private_t, it's a generic void pointer to some unknown struct. -- Certified & Supported Apache Subversion Downloads: http://www.wandisco.com/subversion/download
