> -----Original Message-----
> From: br...@apache.org [mailto:br...@apache.org]
> Sent: dinsdag 12 maart 2013 18:44
> To: comm...@subversion.apache.org
> Subject: svn commit: r1455645 -
> /subversion/trunk/subversion/bindings/javahl/native/SVNClient.cpp
> 
> Author: brane
> Date: Tue Mar 12 17:43:52 2013
> New Revision: 1455645
> 
> URL: http://svn.apache.org/r1455645
> Log:
> Working on isue #4326 (update javahl with new 1.8 APIs).
> 
> * subversion/bindings/javahl/native/SVNClient.cpp (SVNClient::commit):
>    Call svn_client_commit6 (with externals drilldown enabled) instead
>    of svn_client_commit5.
> 
> Modified:
>     subversion/trunk/subversion/bindings/javahl/native/SVNClient.cpp
> 
> Modified:
> subversion/trunk/subversion/bindings/javahl/native/SVNClient.cpp
> URL:
> http://svn.apache.org/viewvc/subversion/trunk/subversion/bindings/javahl
> /native/SVNClient.cpp?rev=1455645&r1=1455644&r2=1455645&view=diff
> ==========================================================
> ====================
> --- subversion/trunk/subversion/bindings/javahl/native/SVNClient.cpp
> (original)
> +++ subversion/trunk/subversion/bindings/javahl/native/SVNClient.cpp Tue
> Mar 12 17:43:52 2013
> @@ -425,8 +425,9 @@ void SVNClient::commit(Targets &targets,
>      if (ctx == NULL)
>          return;
> 
> -    SVN_JNI_ERR(svn_client_commit5(targets2, depth,
> -                                   noUnlock, keepChangelist, TRUE,
> +    SVN_JNI_ERR(svn_client_commit6(targets2, depth,
> +                                   noUnlock, keepChangelist,
> +                                   TRUE, TRUE, TRUE,

This will probably break Subclipse.

The default should be to not go into externals.

Clients like subclipse pass a list of targets and depth empty, while this will 
just commit every external when committing the root of the wc with depth empty.

        Bert 

Reply via email to