On Fri, Apr 12, 2013 at 8:27 PM, Daniel Shahaf <danie...@elego.de> wrote: > Prompted by Julian's review of this freshly-minted public API on IRC: > > 1. Question to API consumers (eg, client developers): would you find > this API useful? For reference, the current docstring is attached. > I think it *may be* useful for our client for diagnostic or logging purpose.
> 2. Should we print the symbolic name in release builds? For example: > No! > > 3. Should the API return the error code, or the error code without the > "SVN_ERR_" prefix? I think stripping the error code is better because > then users who search for the error code will be more likely to reach > the users@ archive (with helpful posts) than commits@ archive (which > are unlikely to contain the information they seek). Julian disagrees, > but I'll let him present his own case :-) > > I also attached a patch which implements (2), in case we want it. > (It'll be trivial to modify it to suit whichever route we pick for (2) > and (3).) I suggest to leave prefix for future extension to return APR error codes symbolic names too. -- Ivan Zhakov
