On Mon, May 20, 2013 at 5:47 PM, Philip Martin <philip.mar...@wandisco.com> wrote: > Ivan Zhakov <i...@visualsvn.com> writes: > >> On Wed, Mar 27, 2013 at 10:39 PM, <cmpil...@apache.org> wrote: >>> Author: cmpilato >>> Date: Wed Mar 27 18:39:56 2013 >>> New Revision: 1461775 >>> >>> URL: http://svn.apache.org/r1461775 >>> Log: >>> * subversion/include/svn_error.h >>> (SVN_ERR_ASSERT): Make this just a wrapper around SVN_ERR_ASSERT_E. >>> >> It seems to be incorrect change, because expr gets evaluated before >> expanding SVN_ERR_ASSERT_E macro and we get just expression value >> instead of expression itself. At least on Windows with VC10. > > Could you give a bit more information. With GCC > > SVN_ERR_ASSERT(1+1==3); > > produces > > ../src/subversion/svn/status-cmd.c:275: (apr_err=SVN_ERR_ASSERTION_FAIL) > svn: E235000: In file '../src/subversion/svn/status-cmd.c' line 275: > assertion failed (1+1==3) > Aborted > > Are you saying that VC10 produces something different? > Yes, with VC10 I get "assertion failed (3)"
-- Ivan Zhakov CTO | VisualSVN | http://www.visualsvn.com
