Hi,

After the release of 1.8, the crash reports for TortoiseSVN are already coming in.

Number one crash is during an update.

In libsvn_wc/update_editor.c, window_handler(), line 1012:

  if (err)
    {
      /* We failed to apply the delta; clean up the temporary file.  */

svn_error_clear(svn_io_remove_file2(hb->new_text_base_tmp_abspath, TRUE,
                                          hb->pool));
    }

here the hb->new_text_base_tmp_abspath is NULL, which results later in a null-pointer access exception.

Is it possible to get there without a temp file being created?

I suggest to check for this before trying to remove it:

  if (err)
    {
      if (hb->new_text_base_tmp_abspath)
        /* We failed to apply the delta; clean up the temporary file.  */

svn_error_clear(svn_io_remove_file2(hb->new_text_base_tmp_abspath, TRUE,
                                            hb->pool));
    }


Stefan

--
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest interface to (Sub)version control
   /_/   \_\     http://tortoisesvn.net

Reply via email to