On Sat, Jun 29, 2013 at 5:01 PM, Greg Stein <gst...@gmail.com> wrote: > Looks good. One small note: > > On Sat, Jun 29, 2013 at 3:51 PM, <rhuij...@apache.org> wrote: >... >> svn_hash_sets(iprops_ctx->curr_iprop->prop_hash, >> apr_pstrdup(iprops_ctx->pool, >> iprops_ctx->curr_propname->data), >> - prop_val); >> - /* Clear current propname and propval in the event there are >> - multiple properties on the current path. */ >> + val_str); > > This assumes that the propname has been seen *before* the propval. The > server sends it in the proper order, but a comment noting this would > be good. > > Or even a test that curr_propname->len > 0 (otherwise, SVN_ERR_XML_MALFORMED).
Oop! My bad. It is further up in the diff context. Already there! Thx, -g
