Roderich Schupp <roderich.sch...@gmail.com> writes: > One small nit with the version for trunk, though: svn_hash_sets is actually > apr_hash_set(hash, key, strlen(key), val), i.e. it assumes key is a > NUL terminated string. Strings in Perl are usually specified as (pointer, > len) > pairs (because they may contain NUL bytes). But AFAIK Perl also > guarantees that there is always a trailing NUL byte at pointer+len, > so using strlen(key) should be safe here.
apr_pstrmemdup guarantees a null byte. -- Philip Martin | Subversion Committer WANdisco | Non-Stop Data
