On Thu, Jul 25, 2013 at 4:39 PM, Ben Reser <b...@reser.org> wrote: > svn_hash_gets() has a similar issue but can't be fixed with a macro > since it has a return value.
There are far fewer cases where svn_hash_gets() results in extra work. At first I thought it might not be worth fixing it since you have to turn it into a function. But then I ran into the cases in libsvn_wc and libsvn_delta and I think we should fix it as well. bindings/javahl/native/org_apache_subversion_javahl_ConfigImpl_Category.cpp 62: svn_hash_gets(cfgdata, category.c_str())); libsvn_repos/authz.c 516: if (svn_hash_gets(checked_groups, &group_user[1])) libsvn_fs_base/fs.c 450: value = svn_hash_gets(fs->config, dbconfig_options[i].config_key); libsvn_wc/status.c 917: repos_lock = svn_hash_gets(wb->repos_locks, // does a svn_fspath__join() libsvn_wc/status.c 2464: repos_lock = svn_hash_gets(fb->edit_baton->wb.repos_locks, // dos a svn_fspath__join() libsvn_wc/wc_db.c 11081: iprops = svn_hash_gets(wcroot_iprops, // does a svn_dirent_join() libsvn_delta/editor.c 148: SVN_ERR_ASSERT(svn_hash_gets((editor)->completed_nodes, \ // uses svn_relpath_dirname()
