On Tue, Oct 15, 2013 at 7:34 AM, Branko Čibej <br...@wandisco.com> wrote:
> On 15.10.2013 07:29, stef...@apache.org wrote: > > Author: stefan2 > > Date: Tue Oct 15 05:29:39 2013 > > New Revision: 1532193 > > > > URL: http://svn.apache.org/r1532193 > > Log: > > Introduce svn_stringbuf_from_stream() as symmetric counterpart to > > svn_stream_from_stringbuf() and use it in one place. > > On general principles, I'd prefer not adding a public API if the > implementation happens to be used in only one place in our code. It > would be better IMO to make this a private function, and only expose it > to the public if we find a real need for it. We're allowed to use > private APIs between our own libraries, and our public API is already > far too verbose. > There will be more usages before I leave for London. -- Stefan^2.
