On 18.11.2013 03:50, Justin Erenkrantz wrote: > On Sun, Nov 17, 2013 at 7:34 AM, Bert Huijben <[email protected] > <mailto:[email protected]>> wrote: > > But I would also like to recommend/ask that we start bundling > Sqlite with > Subversion, to allow optimizing for the specific version we use for a > release without risking future breakage. > > > If we use the amalgamation, are all of the symbols private to our > usage? That is, if someone links in libsvn_wc and their application > also links in the system (or another) sqlite, aren't we going to have > a runtime conflict? -- justin
Nope, they're private. We force the SQLite APIs to be declared static (that's a feature of the amalgamated code), and we only export the API table pointer and a couple function pointers within our own namesapce; see the last few lines in http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/sqlite3wrapper.c?view=markup — Brane -- Branko Čibej | Director of Subversion WANdisco // Non-Stop Data e. [email protected]
