Hi,

I've noticed that running 'svnadmin create --pre-1.4-compatible REPOS_NAME'
around trunk@r1546963 incorrectly errors out:
[[[
svnadmin: E200037: Failed to parse version number string '1.3.0(null)'
svnadmin: E200004: Could not convert '0(null)' into a number
]]]

This error happens with every --pre-1.x-compatible option and is a regression
against 1.8.x introduced in r1509915 [1].  I've attached a patch to fix this
problem.

[1] http://svn.apache.org/viewvc?view=revision&revision=1509915


Thanks and regards,
Evgeny Kotkov
Index: subversion/svnadmin/svnadmin.c
===================================================================
--- subversion/svnadmin/svnadmin.c      (revision 1546963)
+++ subversion/svnadmin/svnadmin.c      (working copy)
@@ -720,7 +720,8 @@ subcommand_create(apr_getopt_t *os, void *baton, a
                                  opt_state->compatible_version->patch,
                                  opt_state->compatible_version->tag
                                  ? "-" : "",
-                                 opt_state->compatible_version->tag));
+                                 opt_state->compatible_version->tag
+                                 ? opt_state->compatible_version->tag : ""));
     }
 
   if (opt_state->compatible_version)
Fix the "Failed to parse version number string '1.3.0(null)'" error when
running svnadmin create --pre-1.x-compatible.  Follow-up to r1509915.

* subversion/svnadmin/svnadmin.c
  (subcommand_create): Correctly handle the absense of COMPATIBLE_VERSION->TAG
    when setting the SVN_FS_CONFIG_COMPATIBLE_VERSION.  If 'svnadmin create' is
    called with one of the --pre-1.x-compatible options, the TAG is NULL, so we
    should avoid constructing unparseable version strings like "1.3.0(null)".

Patch by: Evgeny Kotkov <evgeny.kotkov{_AT_}visualsvn.com>

Reply via email to