On 2/6/14, 5:47 AM, Stefan Sperling wrote: > Arguably, we could add a check of the on-disk state before we delete > the file in meta data. But implications would have to be investigated > first (whether to completely fail in the recursive delete case, > whether this would hurt performance a lot, etc.).
Such a check would only protect against lacking permissions when that check was made. You'd still have the possibility for the WC to get in this state if the permission changed between that check and the execution of the work queue. The error message seems easy enough to understand in my opinion: svn: E155009: Failed to run the WC DB work queue associated with '/Users/breser/wedged-wc/wc', work item 4 (file-remove foo) svn: E000013: Can't remove file '/Users/breser/wedged-wc/wc/foo': Permission denied I'd expect most people could figure out that they need to resolve the permission issue and run cleanup again. So I don't think there's much benefit in such a check.
