On 17 mar 2014, at 10:40, Bert Huijben <b...@qqmail.nl> wrote: > > >> -----Original Message----- >> From: Markus Schaber [mailto:m.scha...@codesys.com] >> Sent: maandag 17 maart 2014 10:07 >> To: Jason Kresowaty; dev@subversion.apache.org >> Subject: AW: Subversion checked-out files not indexed in Windows search >> >> Hi, >> >> Von: Jason Kresowaty [mailto:ja...@binarycoder.net] >>> On 3/13/2014 9:08 AM, Branko Čibej wrote: >>>> I understand that; it simply means that when we install a file from >>>> .svn/tmp into the working copy proper, we have to change that >>>> attribute; either before or after the file is moved into place. >>> >>> When this came up on ACLs, there seemed to be a lot of resistance to >> changing >>> the file after it was in place. Kind of switching the subject, but if you're >>> okay with changing files after they are in place, consider also propagating >>> the ACL at that time too. >> >> What about first setting the ACL and attributes while the file still is in >> the >> temp folder, and then moving the file to the final place? > > To what would you want to set the ACL? > > The code snippet posted makes the file inherit the ACL of its parent > directory, which in this case would be the temp directory. > > Which is exactly the current behavior. > > And updating these attributes one at a time during checkout would be huge > (not a small) performance killer during checkout, as both operations would be > updating the MFT. > > We should try to perform as much operations as possible while having the > files open anyway, as each file open (which at the kernel level includes > operations as setting properties) will involve virus scanners, etc. > > > With the current trunk code the best solution might be to just remove the > setting of the 'don't index' property, as the current code already moves the > files in place while still open and 100% locked from indexers. > (Those indexers really slowed us down on Windows XP and 7 around the time > that we introduced this flag as the indexer opened the file between us > creating and moving the file)
Taking that line of thought one step further; The "don't index' property should probably be set on 'pristine' and 'wc.db' (for completeness also on 'entries' and 'format') rather than on '.svn'. Notably avoiding to set/inherit that property on tmp. I think setting the property is quite important, particularly for 'pristine'. Should solve the indexing issue but not the ACL issue. /Thomas Å.
