Re this nomination for 1.8.x: * r1570642, r1585686 Fix memcached support. Justification: Enabling memcached causes crashes without these fixes. Regression from 1.7. Votes: +1: stsp, philip
On trunk, it looks like the following doc fixes are required to match the code changes made in r1570642. [[[ Index: subversion/include/private/svn_cache.h =================================================================== --- subversion/include/private/svn_cache.h (revision 1586265) +++ subversion/include/private/svn_cache.h (working copy) @@ -188,6 +188,10 @@ * if they are strings. Cached values will be copied in and out of * the cache using @a serialize_func and @a deserialize_func, respectively. * + * If @a deserialize_func is NULL, then the data is returned as an + * svn_stringbuf_t; if @a serialize_func is NULL, then the data is + * assumed to be an svn_stringbuf_t. + * * The cache stores up to @a pages * @a items_per_page items at a * time. The exact cache invalidation strategy is not defined here, * but in general, a lower value for @a items_per_page means more @@ -230,7 +234,7 @@ * other caches. @a *cache_p will be allocated in @a result_pool. * * If @a deserialize_func is NULL, then the data is returned as an - * svn_string_t; if @a serialize_func is NULL, then the data is + * svn_stringbuf_t; if @a serialize_func is NULL, then the data is * assumed to be an svn_stringbuf_t. * * These caches are always thread safe. @@ -344,7 +348,7 @@ * will be allocated in @a result_pool. * * If @a deserialize_func is NULL, then the data is returned as an - * svn_string_t; if @a serialize_func is NULL, then the data is + * svn_stringbuf_t; if @a serialize_func is NULL, then the data is * assumed to be an svn_stringbuf_t. * * If @a thread_safe is true, and APR is compiled with threads, all ]]] - Julian
