On 15 February 2013 14:48,  <phi...@apache.org> wrote:
> Author: philip
> Date: Fri Feb 15 10:48:25 2013
> New Revision: 1446504
>
> URL: http://svn.apache.org/r1446504
> Log:
> Support freezing multiple repositories in libsvn_repos and
> make svnadmin support both:
>
[..]

> Modified: subversion/trunk/subversion/svnadmin/svnadmin.c
> URL: 
> http://svn.apache.org/viewvc/subversion/trunk/subversion/svnadmin/svnadmin.c?rev=1446504&r1=1446503&r2=1446504&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/svnadmin/svnadmin.c (original)
> +++ subversion/trunk/subversion/svnadmin/svnadmin.c Fri Feb 15 10:48:25 2013
> @@ -289,6 +289,8 @@ static const apr_getopt_option_t options
[...]

> +  if (!opt_state->filedata)
> +    {
> +      /* One repository on the command line. */
> +      paths = apr_array_make(pool, 1, sizeof(const char *));
> +      APR_ARRAY_PUSH(paths, const char *) = opt_state->repository_path;
> +    }
> +  else
> +    {
> +      /* All repositories in filedata. */
> +      paths = svn_cstring_split(opt_state->filedata->data, "\n", FALSE, 
> pool);
Hi Philip,

This code does not handle CR LF which is standard on Windows. So
'svnadmin freeze -M' does not work on Windows. Changing code to:
[[
paths = svn_cstring_split(opt_state->filedata->data, "\n\r", TRUE, pool);
]]

Fixes the problem. Btw it seems there is no tests for 'svnadmin freeze -M' case

> +    }
> +
[..]


-- 
Ivan Zhakov
CTO | VisualSVN | http://www.visualsvn.com

Reply via email to