Bert Huijben wrote: >> URL: http://svn.apache.org/r1619476 >> Log: >> Fix missing diff header lines when diffing a file that has only property >> changes. >> >> * subversion/libsvn_client/diff.c >> (diff_content_changed): If the text diff was empty, assume no header was >> printed (unless we printed one explicitly).
>> - /* We have a printed a diff for this path, mark it as visited. */ >> - *wrote_header = TRUE; >> + /* If we have printed a diff for this path, mark it as visited. */ >> + if (exitcode == 1) >> + *wrote_header = TRUE; > > I don't think we can really trust the exit code of any diff tool, to imply > whether it reported a diff or not? > > We certainly don't document any of these dependencies. > > Does this even work for our own diff tools? The book says: "Subversion expects that your program return an error code of 1 if your program detected differences, or 0 if it did not - any other error code is considered a fatal error" <http://svnbook.red-bean.com/nightly/en/svn.advanced.externaldifftools.html#svn.advanced.externaldifftools.diff> - Julian
