On 27 August 2014 19:42, Stefan Fuhrmann <stefan.fuhrm...@wandisco.com> wrote: > On Tue, Aug 26, 2014 at 4:00 PM, C. Michael Pilato <cmpil...@collab.net> > wrote: >> >> On 08/26/2014 09:02 AM, Stefan Fuhrmann wrote: > > >> >> > Note that we >> > never include such headers in current Subversion code except >> > "fs-loader.h" and tests. >> > >> > >> > Would moving the declarations (2 structs, 10 functions) >> > to a new "include/private/svn_fs_fs_private.h" be sufficient >> > in your opinion? >> >> I should think that would be sufficient. But then, it wasn't my opinion >> that you solicited. :-) > > > Implemented in r1620909. > Stefan,
This is completely wrong approach. Please revert immediately. Proper way is to implement three specific semi-private functions in libsvn_fs_fs for collecting stats, dumping and loading FS indexes and then use in svnfsfs. -- Ivan Zhakov