On 5 February 2015 at 17:22, Branko Čibej <br...@wandisco.com> wrote: > On 05.02.2015 11:13, Ivan Zhakov wrote: >> On 5 February 2015 at 03:44, <br...@apache.org> wrote: >>> Author: brane >>> Date: Thu Feb 5 00:44:57 2015 >>> New Revision: 1657451 >>> >>> URL: http://svn.apache.org/r1657451 >>> Log: >>> On the reuse-ra-session branch: Add explicit session reuse in libsvn_client. >>> >> Cool stuff! Two minor nits are below. > > Thanks! Fixed in r1657574, along with a few more of the same ilk. > > I prefer to keep the svn_error_t* return from the release function and > write code as if it actually can fail,. > I don't have opinion what is better, so I'm fine with both approaches. Anyway this is private API and we can change it anytime.
-- Ivan Zhakov