> -----Original Message-----
> From: Branko Čibej [mailto:br...@wandisco.com]
> Sent: maandag 16 februari 2015 03:29
> To: Subversion Development
> Subject: Re: Time to branch 1.9

>   * 4558, 4559, 4560: These are all about pin-externals. They shouldn't
>     take too long to fix; basically, the pin-externals feature needs a
>     lot more tests to catch the trivial errors sooner.

I fixed issues
#4558 - pin-externals fails to handle spaces properly 
#4559 - svn copy segfaults with pin externals

#4560 is a documentation issue and I think this can be fixed after branching.
(Not working on a fix myself)

When writing a testcase I tried to create ugly samples and did something like
svn:external:
"../../deps/sqlite ext/sqlite"

Which applies "../deps/sqlite" to the current url to determine the url for the 
external. After pinning this usually won't work.

I think that (as nice to have) we should pin these paths to an actual 
repository relative url *or* not pin them. The current behavior of pinning them 
with a peg revision (most likely pointing to a different path after the copy) 
is very likely to cause the external to break after the copy.

        Bert

Reply via email to