Philip Martin <philip.mar...@wandisco.com> writes: > Branko Čibej <br...@wandisco.com> writes: > >> Alternatively, we could just stop supporting broken 1.x libtool. > > Building from tarballs would be unaffected if we bumped the libtool > requirement. Only people running autogen.sh would need the newer > libtool. Libtool 1.5 dates from 2003. > > The current code is bit like magic, it dates back to r850874 and fixes > issue 2031. While we have two C++ libraries, libsvnjavahl and > libsvn_auth_kwallet, the extra library is only used for LINK_JAVAHL_CXX > not LINK_CXX_LIB. I think that means nobody builds kwallet with libtool > 1.4 possibly because such old systems do not have KDE or are server-only > for Subversion.
This whole bit of code has too much magic. FreeBSD 10 uses clang and from the command line this works: c++ x.o -o x -lstdc++ because clang converts -lstdc++ to -lc++. However when libtool invokes c++ to link it also passes -nostdlib and this fails: c++ x.o -o x -nostdlib -lstdc++ /usr/bin/ld: cannot find -lstdc++ because the conversion doesn't happen. So to write a runtime check using something like AC_CHECK_LIBS or AC_LINK_IFELSE the check has to use libtool or use the same flags as libtool. I'm not going to try and write that. -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*
