Carlos Martín Nieto wrote on Mon, Mar 30, 2015 at 16:58:57 +0200:
> +++ autogen.sh        (working copy)
> -        configfile=${LIBTOOL_CONFIG-`cd $ltpath/../share/libtool/config ; 
> pwd`/$file}
> +        configfile=${LIBTOOL_CONFIG-$(cd $ltpath/../share/libtool/config ; 
> pwd)}/$file

Is it safe to use $(...)?  At least Solaris sh doesn't support it, and
there are only two uses in configure — one is in dead code and one is in
a string only used for error messages.  I suppose it would be safer to
retain the `...`.

Also, please use a text/* MIME type for patch attachments, rather than
text/plain.

Looks good otherwise.

Cheers,

Daniel

Reply via email to