> Wouldn't it be easier, and a smaller patch, to add a check in > svn_repos_create that the FS type is valid /before/ creating the > repository structure? This would also avoid adding yet another public API.
As I understand there is no public API for checking if FS-type is valid and corresponding FS module is available (for DSO-enabled builds). Even if we do a preliminary check like that, there are a number of other errors that could occur during module loading and filesystem creation. I used 'invalid-fs-type' in test just as simple and predictable way to fail the filesystem creation. I agree that it would be better to avoid adding yet another public API, but svn_io_remove_dir_contents() function might be useful for both Subversion and third-party public API clients.
