Hi, On 09/04/15 10:37, Bert Huijben wrote: > On 09/04/15 10:04, Andreas Stieger wrote: >> >> I am getting the following test failures with 1.9.0-beta1 with the very >> recently released SQLite 3.8.9. I have not yet investigated but will dump >> the log anyway. >> >> [ 875s] [050/110] >> wc-queries-test................................................FAILURE >> [...] >> [ 4950s] At least one test FAILED, checking >> /home/abuild/rpmbuild/BUILD/subversion-1.9.0-beta1/tests.log >> [ 4950s] FAIL: wc-queries-test 3: test query expectations >> [ 4950s] Summary of test results: >> [ 4950s] 2180 tests PASSED >> [ 4950s] 71 tests SKIPPED >> [ 4950s] 45 tests XFAILED (1 WORK-IN-PROGRESS) >> [ 4950s] 1 test FAILED >> [ 4950s] SUMMARY: Some tests failed. >> [ 4950s] >> [ 4950s] Makefile:521: recipe for target 'check' failed >> [ 4950s] make: *** [check] Error 1 >> [ 4950s] + cat fails.log >> [ 4950s] [[[ >> [ 4950s] svn_tests: E200006: STMT_SELECT_EXTERNALS_DEFINED: Uses externals >> with only 1 index component: (wc_id=? ) >> [ 4950s] SELECT local_relpath, def_local_relpath FROM externals WHERE (wc_id >> = ?1 AND def_local_relpath = ?2) OR (wc_id = ?1 AND (((def_local_relpath) >> > (CASE (?2) WHEN '' THEN '' ELSE (?2) || '/' END)) AND ((def_local_relpath) >> < CASE (?2) WHEN '' THEN X'FFFF' ELSE (?2) || '0' END))) >> [ 4950s] svn_tests: E200042: Additional errors: >> [ 4950s] svn_tests: E200035: |SEARCH TABLE externals USING COVERING INDEX >> I_EXTERNALS_DEFINED (wc_id=?) >> [ 4950s] FAIL: wc-queries-test 3: test query expectations >> [ 4950s] ]]] >> [ 4950s] >> [ 4950s] + exit 1 >> [ 4950s] error: Bad exit status from /var/tmp/rpm-tmp.oHqq5V (%check) > > This tells me that it started using the index in a less efficient way... > Or more precisely a useless way. But as it is just the EXTERNALS table I > don't think it will really affect end user performance in a measurable way. > > We should probably add a new record to the stats table to work around > this query optimizer change.
I see that 1.8.x affected as well, and can confirm that r1672295 fixes the test for both 1.8.x and 1.9.x, while not breaking anything. Maybe propose a backport for previous releases too? Andreas
