Is this comment in cache-membuffer.c:combine_key correct?
/* scramble key DATA. All of this must be reversible to prevent key
* collisions. So, we limit ourselves to xor and permutations. */
data[1] = (data[1] << 27) | (data[1] >> 37);
data[1] ^= data[0] & 0xffff;
data[0] ^= data[1] & APR_UINT64_C(0xffffffffffff0000);
I don't see why this needs to be reversible, and it's not clear it is
reversible.
The comment was added in r1458643 on the cache-server branch
http://svn.apache.org/viewvc?view=revision&revision=r1458643
--
Philip Martin | Subversion Committer
WANdisco // *Non-Stop Data*
