On 19.08.2015 18:26, stef...@apache.org wrote: > Author: stefan2 > Date: Wed Aug 19 16:26:05 2015 > New Revision: 1696626 > > URL: http://svn.apache.org/r1696626 > Log: > * subversion/libsvn_ra_serf/util.c > (ssl_convert_serf_failures): When doing array size calculations, refer to > the array object only. > > Modified: > subversion/trunk/subversion/libsvn_ra_serf/util.c > > Modified: subversion/trunk/subversion/libsvn_ra_serf/util.c > URL: > http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/util.c?rev=1696626&r1=1696625&r2=1696626&view=diff > ============================================================================== > --- subversion/trunk/subversion/libsvn_ra_serf/util.c (original) > +++ subversion/trunk/subversion/libsvn_ra_serf/util.c Wed Aug 19 16:26:05 2015 > @@ -65,7 +65,9 @@ ssl_convert_serf_failures(int failures) > apr_uint32_t svn_failures = 0; > apr_size_t i; > > - for (i = 0; i < sizeof(serf_failure_map) / (2 * sizeof(apr_uint32_t)); ++i) > + for (i = 0; > + i < sizeof(serf_failure_map) / (sizeof(serf_failure_map[0])); > + ++i) > { > if (failures & serf_failure_map[i][0]) > {
This one would've been better served by introducing a constant for the array size ... -- Brane
