On Wed, Aug 26, 2015 at 8:26 AM, Branko Čibej <br...@wandisco.com> wrote:
> On 26.08.2015 07:34, Daniel Shahaf wrote:
> > Branko Čibej wrote on Wed, Aug 26, 2015 at 07:26:47 +0200:
> >> On 25.08.2015 23:12, Stefan Fuhrmann wrote:
> >>> On Tue, Aug 25, 2015 at 4:43 PM, Branko Čibej <br...@wandisco.com>
> wrote:
> >>>> Daniel suggested inserting a dummy handler if we don't have the GPG
> >>>> agent support. I think that may be the only reasonable solution for
> both
> >>>> trunk and 1.9.1 (or .x if we don't thing it's important enough for
> .1).
> >>>>
> >>>> The real effort here is double-checking that a dummy handler won't
> break
> >>>> credentials resolution.
> >>>>
> >>> I think just starting with a full copying the GPG agent handler and
> >>> making each call return "failed" should work. Didn't try it, though.
> >> I'll give this a go and hopefully come up with a test case, too.
> > I think you might be able to get away with:
> >
> > static svn_auth_provider_t dummy = {
> > .cred_kind = "dummy", NULL, NULL, NULL
> > };
>
> I just added a private function to return a dummy simple provider; see
> r1697824.
>
Thanks for taking care of that! Reviewed and approved.
-- Stefan^2.
