On 10.09.2015 21:40, Branko Čibej wrote: > On 10.09.2015 21:06, Stefan Fuhrmann wrote: >> On Thu, Sep 10, 2015 at 9:00 PM, Bert Huijben <b...@qqmail.nl> wrote: >> >>>> -----Original Message----- >>>> From: stef...@apache.org [mailto:stef...@apache.org] >>>> Sent: donderdag 10 september 2015 20:14 >>>> To: comm...@subversion.apache.org >>>> Subject: svn commit: r1702305 - >>>> /subversion/trunk/subversion/libsvn_subr/stream.c >>>> >>>> Author: stefan2 >>>> Date: Thu Sep 10 18:13:52 2015 >>>> New Revision: 1702305 >>>> >>>> URL: http://svn.apache.org/r1702305 >>>> Log: >>>> APR file based streams shall not superficially support read or write >>>> functions when we know that the APR file itself does not. Instead, >>>> they will now return a "not supported" stream error. >>>> >>>> Note that this check is not perfect for arbitrary APR file handles >>>> (may enable more functions than the handle actually supports) but >>>> works correctly for our STD* streams and the files opened through >>>> our svn_io_* API. >>> This patch breaks JavaHL's tunnel tests on at least one buildbot. >>> >>> >>> https://ci.apache.org/builders/svn-x64-centos-gcc/builds/277/steps/Test%20bindings%20fsfs%2Bra_serf/logs/stdio >>> >>> (The JavaHL tests PASS on Windows) >>> >> Ok. I'll wait for Brane to maybe have a look at it. Could well be >> that we uncovered an inconsistency in the bindings. > I noticed the failure; I'll take a look in the morning. The > "inconsistency" is probably in APR, since AFAIK it uses anonymous pipes > on Windows but just plain file handles on Unix in this particular case. > > I'm surprised the test passed on OSX but failed on CentOS/Linux, though.
Ah, it did not pass on OSX, I just didn't wait long enough. That's good (I think ...) -- Brane
