Of course I would be glad to modify the patch, but... shall we content ourselves with the somewhat elusive fs-type? :)
Roberto On Mon, Dec 21, 2015 at 4:23 PM, Daniel Shahaf <d...@daniel.shahaf.name> wrote: > On Mon, Dec 21, 2015, at 15:16, Bert Huijben wrote: > > > > > > > -----Original Message----- > > > From: Daniel Shahaf [mailto:d...@daniel.shahaf.name] > > > Sent: maandag 21 december 2015 15:58 > > > To: Roberto Reale <roberto.real...@gmail.com> > > > Cc: Philip Martin <philip.mar...@wandisco.com>; > > > dev@subversion.apache.org > > > Subject: Re: [PATCH] improved behaviour of tools/backup/hot-backup.py > > > > > > > > I think (3) should fall back to $REPOS_DIR/db/fs-type (which is > > > guaranteed to exist) rather than to umask. (The umask has the right > > > dimension — permission bits — but using it might surprise users.) > > > > Are you sure this 'must exist'? > > > > When I accidentally tried to use a wrong directory some weeks ago (while > > working on libsvn_fs_git) I found that when that file is missing we > assume > > that the filesystem is BDB. > > Without checking the code, I suspect you're right, and that file only > exists > for repositories created by svn 1.1 or later... > > Good catch :-) > > Daniel >
