Re: [PATCH] Fix for access violation in svn_fs__path_valid()

[Stefan]

On 2/7/2016 01:22, Daniel Shahaf wrote:
Stefan wrote on Mon, Feb 01, 2016 at 00:34:32 +0100:
+++ fs-loader.c (working copy)
@@ -461,7 +461,8 @@
    if (! svn_utf__cstring_is_valid(path))
      {
        return svn_error_createf(SVN_ERR_FS_PATH_SYNTAX, NULL,
-                               _("Path '%s' is not in UTF-8"), path);
+                               _("Path '%s' is not in UTF-8"),
+                               path ? path : "NULL");
Is this actually a problem?  svn_error_createf() uses apr_pvsprintf()
which (by code inspection) accepts NULL here.
TBH I didn't look further... Just assumed that apr_pvsprintf() would 
just be a redefine. If it's a specific implementation which checks for 
NULL here and handles it, then pls disregard my patch.

P.S. I tried to check out the function definition myself, but could only 
spot the declaration in the apr source. Couldn't trace down where the 
function is defined...

Regards,
Stefan