On 28 March 2016 at 16:37, Stefan Sperling <[email protected]> wrote: > On Mon, Mar 28, 2016 at 04:13:11PM +0300, Ivan Zhakov wrote: >> On 20 March 2016 at 01:18, <[email protected]> wrote: >> > { >> > if (err->apr_err == SVN_ERR_CANCELLED) >> > { >> > - svn_error_clear(err); >> > *may_save_plaintext = FALSE; >> > - return SVN_NO_ERROR; >> > + return err; >> Daniel, do you know what was the original idea behind ignoring the >> SVN_ERR_CANCELLED error? I see stsp committed the original code in >> r870804, so there's probably some rationale behind it. >> >> Stefan, do you remember any details? > > I don't think there was a special reason to ignore the error. > > The question is whether we want Ctrl-C to mean "no" at the plaintext > prompt, or whether it should abort the process. > > I agree with Daniel's patch. Ctrl-C should abort the process. OK. Thanks for clarification! I just wanted to double check that we're not missing something important.
-- Ivan Zhakov
