On 8/24/2016 20:07, Evgeny Kotkov wrote: > Bert Huijben <b...@qqmail.nl> writes: > >> Nice fix :-) >> >> Do you have any numbers on the resulting memory usage compared to the >> previous version. I would imagine that this could really help on updates >> with a lot of files, especially on threaded apache. > Thanks! > > The difference is 32 bytes per every svn_stream_write() call that's done > while handling the request. A skelta-style update for 700 MB of deltified > contents (one file) now requires 2.5 MB less memory. > > This isn't a lot, but I think it's a nice thing to have. > > Another reason for this change is that every created apr_bucket_brigade > adds a pool cleanup handler, and keeping an unnecessary pile of handlers > just didn't feel right. > > > Regards, > Evgeny Kotkov
Would this (and your other two commits) be something which should be considered to backport to 1.9 (and maybe even 1.8)? As far as I was following the history of this, it sounds like a reasonable improvement worth for a backport, no? Regards, Stefan
smime.p7s
Description: S/MIME Cryptographic Signature
