On 17.02.2017 07:43, Daniel Shahaf wrote: > Evgeny Kotkov wrote on Thu, Feb 16, 2017 at 23:55:19 +0300: >> Stefan Sperling <[email protected]> writes: >> >>>> 1) enabling it on trunk permanently (and disabling it on stable branches) >>>> >>>> 2) tagging a wc that has the patch applied >>>> >>>> 3) committing the patch to a branch and <handwave>arrange for the tag to >>>> incorporate the changes from that branch</handwave>. >>> 4) Encourage people to compile alpha/beta/rc with --enable-maintainer-mode. >> 4) seems like an appropriate option to me. >> >> This is because we only ship the source code, and I think that those who >> actually build it should be in charge of enabling or disabling the debug >> features. > So perhaps we should change the guard from > . > #ifdef SVN_DEBUG > . > to > . > #if defined(SVN_DEBUG) || > defined(FSFS_VERIFY_AS_REVISION_BEFORE_CURRENT_PLUS_PLUS) > . > to make it easier to enable that one feature, without everything else > that maintainer mode brings.
--enable-debug and --enable-maintainer-mode are separate flags. Not quite orthogonal, but separate. -- Brane
