Perhaps the revprop load operation was designed to support some kind of 'refresh' of the revprops after an earlier dump/sync. In that case it might make sense to have a specific operation, as that would really change the operation to something completely else.
Bert ________________________________ From: Markus Schaber <m.scha...@codesys.com> Sent: Wednesday, April 26, 2017 8:25:58 AM To: Daniel Shahaf; dev@subversion.apache.org Subject: RE: 'svnadmin load-revprops' as first-level command? Hi, From: Daniel Shahaf [mailto:d...@daniel.shahaf.name] > I was going through the 1.10 release notes and I found the new load-revprops > / dump-revprops subcommands: > > https://subversion.apache.org/docs/release-notes/1.10#svnadmin-revprops > New svnadmin dump-revprops and svnadmin load-revprops subcommands > > […] svnadmin dump-revprops will save the current values of all > revision properties to a dump file. svnadmin load-revprops can be > used to set revision properties in a repository to the values saved > in a dump file. > > I don't dispute the need for such functionality, but is a separate top-level > command the right home for it? I would have expected 'load-revprops' to be > spelled "svnadmin load --only-revprops" or even "svndumpfilter revprops-only > | svnadmin load". > > The rationale is that 'load' and 'load-revprops' take exactly the same data > format and manipulate it in exactly the same way. I guess that, especially for the "dump" case, "dump-revprops" is (or should be) much more efficient than a "dump" piped through "svndumpfilter". For "load", the additional overhead will be smaller, but still there. So I think this functionality should be implemented in svnadmin itself. Note, however, that I wouldn't mind it being an "--only-revprops" option to the existing "load" and "dump" subcommands instead of a new subcommand. And I also don't oppose the idea of "svndumpfilter revprops-only", which clearly has its own use cases. :-) Best regards Markus Schaber CODESYS® a trademark of 3S-Smart Software Solutions GmbH Inspiring Automation Solutions 3S-Smart Software Solutions GmbH Dipl.-Inf. Markus Schaber | Product Development Core Technology Memminger Str. 151 | 87439 Kempten | Germany Tel. +49-831-54031-979 | Fax +49-831-54031-50 E-Mail: m.scha...@codesys.com | Web: http://www.codesys.com | CODESYS store: http://store.codesys.com CODESYS forum: http://forum.codesys.com Managing Directors: Dipl.Inf. Dieter Hess, Dipl.Inf. Manfred Werner | Trade register: Kempten HRB 6186 | Tax ID No.: DE 167014915 This e-mail may contain confidential and/or privileged information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and destroy this e-mail. Any unauthorised copying, disclosure or distribution of the material in this e-mail is strictly forbidden.
