Re: svn commit: r1801108 - in /subversion/trunk/subversion/bindings/javahl/native: Array.cpp CreateJ.cpp Iterator.cpp OperationContext.cpp RemoteSession.cpp RevisionRangeList.cpp

[Stefan Fuhrmann]

On 06.07.2017 23:11, Philip Martin wrote:

Philip Martin <phi...@codematters.co.uk> writes:

I've upgraded my JDK and it produced all these warnings.

Excellent to see these warnings being addressed!

There is a second class of warnings of the form:

   WARNING: JNI local refs: 57, exceeds capacity: 56

They all seem to be off by one. But that could well be
an artefact of the first one too many getting reported.

These are generated in two places: JNIUtil::putErrorsInTrace() and
Java_org_apache_subversion_javahl_util_PropLib_unparseExternals().

I'm not sure how best to fix these so I have a local hack in
JNIUtil::wrappedCreateClientException to remove most of them:

    // Create a local frame for our references
-  env->PushLocalFrame(LOCAL_FRAME_SIZE);
+  env->PushLocalFrame(LOCAL_FRAME_SIZE + 100);

Maybe, it is the SVN_ERR__TRACING section in that method
that causes the overflow?

-- Stefan^2.