Daniel Shahaf <d...@daniel.shahaf.name> writes: >> ------------------------------------------------------------------------ >> r1800836 | philip | 2017-07-04 22:37:52 +0000 (Tue, 04 Jul 2017) | 15 lines >> >> Remove some casts when using APR 2 and fix a "missing volatile" bug that >> was uncovered. >> >> * subversion/include/private/svn_dep_compat.h >> (svn_atomic_casptr, svn_atomic_xchgptr): New. >> >> * subversion/libsvn_fs/fs-loader.c >> (struct fs_type_defn): Add missing volatile to vtable element, change >> type to void * to avoid cast (we lose no type safety since we never >> access the value as any other type). >> (get_library_vtable_direct): Remove explicit cast. >> >> * subversion/libsvn_subr/utf.c >> (atomic_swap): Remove explicit cast.
This probably doesn't warrent an appearance in CHANGES: it is mostly cosmetic. The compilation unit where the qualifier is visible doesn't read the value directly so I think it unlikely the old code misbehaved. -- Philip
