On 14.09.2017 12:26, Paul Hammant wrote: > Thanks. > > Here's what I expect to land - https://github.com/apache/subversion/pull/5
Why o why did you go to the trouble of adding the global variables in svn-viewspec.py? They add exactly zero value and cause nothing but code churn. -1 to that change ... the rest there look cosmetic and OK. BTW, you left trailing spaces on some of the lines (github diff shows them); please fix that. The tests should be in tools/client-side. subversion/tests/cmdline are for testing the main command-line tools, and have their own test infrastructure (which predates PyTest, FWIW). We do not install, nor officially support, the bits in the tools/ directory. Also please read the community guide, especially the part about log messages, before committing. http://subversion.apache.org/docs/community-guide/ > Ten tests - ten passing in less than 0.1s > > I don't know if there is a clean workflow from Git commits back into > Subversion so, I'll make the same commit through the Svn HTTPS > interface, if code review comments are approving. There isn't currently, as far as I know. -- Brane
